Tweak XDAUpgradeValidation to use assembly bindings generated at build time - #747
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The default configuration may lack bindings and erase working redirects during upgrades; generation or safe failure handling is needed.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 1
What changed in this PR
Updates upgrade validation to preserve existing settings while refreshing assembly bindings from a deployed default configuration.
Changes:
- Deploys
openXDA.exe.config.default. - Refreshes assembly bindings during upgrades.
- Preserves the previous configuration as
.prev.
| File | Summary |
|---|---|
Source/Tools/XDAUpgradeValidation/Program.cs |
Applies default assembly bindings during upgrades. |
Source/Applications/openXDA/openXDASetup/openXDASetup.wxs |
Packages the default configuration file. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
elwills
approved these changes
Sep 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new component in the installer deploys a "default config" by the name of
openXDA.exe.config.default. This can be used to observe default settings, but it is now also used byXDAUpgradeValidationto replace theassemblyBindingsection in the persistent config file with a fresh copy that comes from the default config. Effectively, this serves to preserve all config file settings from the prior installation on upgrade except for the assembly bindings which often needs to be upgraded for the new version to function.If the old assembly bindings section needs to be referenced for any reason, it is preserved in the
openXDA.exe.config.prevfile.