Update ux for openai to include space and color#4
Open
leerobertdyer wants to merge 2 commits intoGroveOS:rootfrom
Open
Update ux for openai to include space and color#4leerobertdyer wants to merge 2 commits intoGroveOS:rootfrom
leerobertdyer wants to merge 2 commits intoGroveOS:rootfrom
Conversation
Member
|
Very interesting approach! I mentioned in the the issue my preference for treating the output as clean plaintext so we can easily write pipelines that don't contain unexpected padding, etc. I think I'll stick to that for now. But let's hold on to this, as it might come in handy for a Thanks for considering this Lee! |
Author
|
Awesome yes I see how the prettier version could cause issues downstream with multiple pipes. Making it a flag is a great idea! Is there a flag for this already or is this something I could potentially work on implementing? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the openai script to add a simple background and spacing for the chat's response.
In regards to this issue
It
-Pipes the response through a sed command that replaces the "^" begin line character with "\t" a tab character
-Adds a simple background and text color to the response to make it stand out from remaining terminal text
NOTE
Is there a more convenient way to store reused variables like GRAY and RESET somewhere globally so we might not have to re-code them in different scripts? Or is it better to have them function in isolation?