Repository navigation
release(3.2.3): User-Agent guard-agent-php, lockstep with the engines at 4.3.3 - #25
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Delivers issue: #24
Closes #24
Description
Also: when guardCoreVersion is unset, fill it from Composer's InstalledVersions for rennf93/guard-core-php (leading v stripped), else null.
Changes Version::USER_AGENT from guard-agent/ to guard-agent-php/, bumps Version::VERSION to 3.2.3, adds a CHANGELOG entry and one smoke assertion that the wire User-Agent names the PHP port.
Motivation and Context
Lockstep patch release 3.2.3 across the Guard-Core families (cores 4.3.3, agents 3.2.3).
Type of change
How Has This Been Tested?
make lint LINT_OK and composer validate OK; make test REDIS_HOST=127.0.0.1: 626 passed, 0 failed.
Checklist: