Repository navigation
fix(ip): combine route country verdict and unknown identity like the reference - #142
Merged
Merged
Conversation
…ock ungeolocated under country whitelist like the reference (#141)
github-actions
Bot
added
area: checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #141
I aligned three more TypeScript IP access paths with the reference engine, each verified by running the reference.
checkRouteIpAccessnow combines the route IP list verdict with the route country verdict: false if either is false, true if either is true, otherwise no verdict. A route whitelist match no longer overrides a blocked country.isIpAllowednow allows the unknown client identity unless a whitelist or country whitelist is configured, and a whitelist match skips the country verdict.checkIpCountrynow blocks a client with no geolocation when a country whitelist is configured.I added
tests/test-utils/ip-list-route-country.test.tswith 192 rows generated by running the reference (check_route_ip_access,check_ip_access): route whitelist x route blacklist x blocked countries x whitelist countries x client country, and global whitelist x whitelist countries including the unknown identity. On master 13 of the 192 fail. I updated the websocket guard test that encoded the old unknown-identity denial. Build, lint, test, coverage and conformance pass locally.