Repository navigation
ci(release): publish a tag only from green CI, and re-drive by tag input - #146
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #145
The release workflow of guard-core-ts re-gated at the tag (a tag-push trigger and tests at the tag), after the tag was already immutable, and a manual re-drive read the ref instead of an input. This mirrors Guard-Core/guard-core-rs#156: the release workflow runs no lint or test of its own.
taginput (^v[0-9]+\.[0-9]+\.[0-9]+$), checks it out, compares it to the package version(s) (all five @GuardCore packages), and requires the newest push run of ci.yml, ecosystem-gate.yml and live-smoke.yml on that commit to have succeeded (it waits up to an hour).npm view). ci.yml no longer filters push runs by path, so a docs-only tagged commit still gets the run verify requires.A re-drive is Actions > Release > Run workflow with the tag; it checks the tag out with master's fixed workflow. The tag-push trigger and the tests at the tag are gone.
Tested locally: actionlint clean (the only warnings are pre-existing and identical on master). I ran the CI check step against real commits: the latest release tag passes and a commit whose CI failed is refused. After merging I will dispatch the release with the current latest tag to prove the re-drive path; every package is already published, so publish skips.