Repository navigation
ci(release): gate the tag on the pull request CI instead of re-running checks - #48
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #47
I changed the Release Gate so it checks the same thing the pull request did instead of re-running checks at the tag.
v*tag push or from a new requiredtaginput onworkflow_dispatch, is validated against^v[0-9]+\.[0-9]+\.[0-9]+$, and is checked out asrefs/tags/<tag>.Require green CI on the tagged commitstep: the newest push run of ci.yml, static-analysis.yml, live-smoke.yml on the tagged commit must have concluded success, waiting up to an hour. The script and comment style are the ones from guard-core-rs (ci(release): publish a tag only from green CI, and re-drive by tag input guard-core-rs#156).ci.ymlon the same commit and the same composer.json, so it is already covered by theci.ymlrequirement. No check has to wait for the tag to exist, so the workflow is the single verify job.PR CI gap-filling: every command the old release workflow ran (php -l sweep, the bin/ runners, composer audit, PHP 8.2 to 8.4) is already in
ci.ymlon pull requests, so nothing needed adding.