🧪 Add tests for LLMModelType migration logic

[Gunnarguy]

🎯 What: The testing gap for LLMModelType migration logic was addressed by adding a dedicated XCTestCase.
📊 Coverage: The tests now cover .isDeprecatedRawValue returning true for expected values and false for others. Additionally, they verify the migrate(from:) fallback behavior for deprecated variables to default to .appleIntelligence and unknown values, as well as preserving correct assignments.
✨ Result: Improved test coverage around deprecated model migration handling, ensuring it functions reliably.

---

PR created automatically by Jules for task 71308968779673966 started by @Gunnarguy

Summary by Sourcery

Add unit tests covering LLMModelType deprecation detection and migration behavior.

Tests:

• Add XCTest coverage for LLMModelType.isDeprecatedRawValue across deprecated, current, and invalid raw values.
• Add tests verifying LLMModelType.migrate(from:) maps deprecated and unknown raw values to appleIntelligence and preserves current model assignments.

[google-labs-jules]

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.

---

For security, I will only act on instructions from the user who triggered this task.

[sourcery-ai]

Reviewer's Guide

Adds a new XCTestCase for LLMModelType to cover deprecated raw values and migration behavior from deprecated, current, and unknown string identifiers.

File-Level Changes

Change	Details	Files
Add unit tests for LLMModelType deprecation detection and migration behavior.	Introduce LLMModelTypeTests XCTestCase targeting LLMModelType behavior. Verify isDeprecatedRawValue returns true for known deprecated raw strings and false for current or junk values. Assert migrate(from:) maps all deprecated raw strings to .appleIntelligence. Assert migrate(from:) preserves existing mappings for current raw values (apple_intelligence, on_device_analysis). Assert migrate(from:) falls back to .appleIntelligence for unknown or empty raw strings.	OpenIntelligenceTests/Core/Models/LLMModelTypeTests.swift

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey - I've left some high level feedback:

• The test cases repeat the same raw values across multiple methods; consider extracting arrays of deprecated/current/unknown values and iterating over them to reduce duplication and make future updates to the set of model types easier to maintain.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- The test cases repeat the same raw values across multiple methods; consider extracting arrays of deprecated/current/unknown values and iterating over them to reduce duplication and make future updates to the set of model types easier to maintain.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[Copilot]

Pull request overview

Adds a new XCTestCase to cover the LLMModelType migration helpers used to map deprecated/unknown persisted model keys to supported defaults in the OpenIntelligence engine module.

Changes:

• Introduces LLMModelTypeTests verifying isDeprecatedRawValue(_:) behavior for deprecated vs current vs junk keys.
• Adds tests validating migrate(from:) maps deprecated/unknown keys to .appleIntelligence and preserves current keys.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.