fix(release): build x86_64-unknown-linux-gnu natively instead of with cross#324
Merged
Merged
Conversation
… cross The cross Docker image for x86_64-unknown-linux-gnu uses GCC < 10.4, which triggers an aws-lc-sys build-time panic (GCC memcmp bug, gcc.gnu.org/bugzilla/95189). x86_64-unknown-linux-gnu is the native target on the ubuntu-latest runner, so cross-compilation is unnecessary here. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
x86_64-unknown-linux-gnutarget since the opentelemetry 0.32 stack was bumped (that bump broughtrustls0.23 →aws-lc-rs→aws-lc-sysinto the dep tree).aws-lc-sys's build script panics when it detects a GCC memcmp bug (gcc.gnu.org/bugzilla/95189, fixed in GCC 10.4). Theghcr.io/cross-rs/x86_64-unknown-linux-gnu:mainDocker image ships GCC < 10.4, so the check always trips.aarch64-apple-darwin,aarch64-unknown-linux-gnu,x86_64-unknown-linux-musl) all passed because they use different images or don't hit this code path.x86_64-unknown-linux-gnuis the native target on theubuntu-latestrunner — we don't needcrossat all for it. Switching touse-cross: falsebuilds it with plaincargo, which uses the host GCC (Ubuntu 24.04 ships GCC 13) and sidesteps the issue entirely.Test plan
x86_64-unknown-linux-gnuartifact is produced correctly🤖 Generated with Claude Code