Skip to content

fix: drag-ghost visualTokens null guard + suite refresh_menu hang #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SashSurendran wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: drag-ghost visualTokens null guard + suite refresh_menu hang #42

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3499c7b
fix(bar): guard visualTokens null in drag ghost panel
Aug 31, 2026
a979a1b
fix(suite): don't wait on an inactive omarchy.menu during refresh
Aug 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions hancore.shibumi.bar/core/DragGhostPanel.qml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,23 +51,24 @@ PanelWindow {
Behavior on x {
enabled: root.layoutSession.returning
NumberAnimation {
duration: root.bar.visualTokens.invalidDropDuration
duration: root.bar.visualTokens ? root.bar.visualTokens.invalidDropDuration : 0
easing.type: Easing.OutCubic
}
}

Behavior on y {
enabled: root.layoutSession.returning
NumberAnimation {
duration: root.bar.visualTokens.invalidDropDuration
duration: root.bar.visualTokens ? root.bar.visualTokens.invalidDropDuration : 0
easing.type: Easing.OutCubic
}
}

Rectangle {
anchors.fill: parent
anchors.margins: -Commons.Style.space(1)
radius: Math.min(height / 2, root.bar.visualTokens.pillRadius)
radius: root.bar.visualTokens
? Math.min(height / 2, root.bar.visualTokens.pillRadius) : 0
color: root.layoutSession.targetGroupId !== ""
? Qt.rgba(root.bar.urgent.r, root.bar.urgent.g, root.bar.urgent.b, 0.2)
: Qt.rgba(root.bar.foreground.r, root.bar.foreground.g,
Expand All @@ -92,7 +93,7 @@ PanelWindow {
}

Timer {
interval: root.bar.visualTokens.returnCleanupDuration
interval: root.bar.visualTokens ? root.bar.visualTokens.returnCleanupDuration : 0
running: root.layoutSession.returning
repeat: false
onTriggered: {
Expand Down
10 changes: 10 additions & 0 deletions scripts/shibumi_suite/runtime.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -553,6 +553,16 @@ def reload_payload(self, *, timeout: float = 8) -> None:
)

def refresh_menu(self, *, timeout: float = 8) -> None:
try:
plugins = self.list_plugins()
except RuntimeFailure:
plugins = {}
if not plugins.get("omarchy.menu", {}).get("active"):
# omarchy.menu is unloaded whenever Shibumi's own menu is the
# active bar/menu; callIfLoaded() then always answers "unknown"
# (shell.qml never returns anything else for an unloaded plugin),
# so there is no running instance left to refresh.
return
command = [
self.command("omarchy-shell"),
"shell",
Expand Down