Repository navigation
fix(api): generate download filenames from the exported format - #120
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
GET /api/download/{token}always returnedContent-Disposition: attachment; filename=export.json, regardless of the real export format (JSON, JSONL, CSV or HTML). The filename was hardcoded in the download route, and the download helper storedfile_format="json"for every token, so the metadata needed to build the correct filename was both wrong and inaccessible.This PR:
DownloadService.get_info()now exposes token metadata to the route; the helper resolves the real format (service-reported format → export file extension →jsonfallback) instead of hardcoding"json".ExportFormatLiteral +EXPORT_FORMATSinexport/base.py, re-exported fromciberwebscan.export), replacing five duplicated inlineLiteraldefinitions in the API request models and reusing the set inget_exporter, the download helper and the download route.Verified end-to-end against a local API instance: exports in all four formats download with the matching filename (
export.csv,export.jsonl,export.html,export.json).Related Issue
None (internal code review finding).
Type of Change
Checklist
Screenshots (if applicable)
N/A — API header behavior change; no UI involved.