fix(express-js): bump nanoid to 3.3.18 for GHSA-2v37-7h3g-55p8 - #1094
Open
SnowboardTechie wants to merge 1 commit into
Open
fix(express-js): bump nanoid to 3.3.18 for GHSA-2v37-7h3g-55p8#1094SnowboardTechie wants to merge 1 commit into
SnowboardTechie wants to merge 1 commit into
Conversation
github-actions
Bot
added
the
typescript
SnowboardTechie
marked this pull request as ready for review
August 18, 2026 15:29
SnowboardTechie
force-pushed
the
bryan/express-js-nanoid-floor
branch
from
August 18, 2026 16:28
018d0f0 to
8f73291
Compare
SnowboardTechie
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes proposed
templates/express-js/pnpm-lock.yamlso nanoid resolves to 3.3.18, clearing GHSA-2v37-7h3g-55p8 (high: custom generators can loop indefinitely when size is zero).Context for reviewers
nanoid is transitive here (
vitest → vite → postcss → nanoid, 6 paths), so Dependabot won't file a direct-dependency bump that reaches it.No override is needed for this one.
postcssdeclaresnanoid: ^3.3.16, a range that already admits the patched 3.3.18 — the lockfile was simply still pinned to 3.3.16. Refreshing the lockfile is enough, so the template's security-floor overrides inpnpm-workspace.yamlare untouched and there is no entry to remember to remove later.The advisory currently fails
pnpm auditon any PR whose CI touches this template (seen on #1093, and reproducible onmain).Verified by running the template's CI steps locally against the updated lockfile:
pnpm install --frozen-lockfile,pnpm run checks,pnpm run build, andpnpm audit, all green withNo known vulnerabilities found.Additional information
Lockfile-wide check after the refresh:
grep 'nanoid@' pnpm-lock.yamlshows only 3.3.18.