ci: skip the co-planning dry runs when the Fider token is unavailable - #1095
Open
SnowboardTechie wants to merge 1 commit into
Open
ci: skip the co-planning dry runs when the Fider token is unavailable#1095SnowboardTechie wants to merge 1 commit into
SnowboardTechie wants to merge 1 commit into
Conversation
SnowboardTechie
marked this pull request as ready for review
August 18, 2026 15:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes proposed
coplanning-sync-fider-to-gh.ymlandcoplanning-sync-gh-to-fider.yml, extend the dry-run step's condition fromgithub.event_name == 'pull_request'to also requireenv.FIDER_API_TOKEN != '', so the step is skipped (not failed) when the token isn't available to the run.Context for reviewers
Dependabot-triggered
pull_requestevents receive no repository secrets, so on any Dependabot PR touching the co-planning paths the dry run dies with[ERROR] FIDER_API_TOKEN environment variable must be set— both sync checks showed this on #1093. External-fork PRs would hit the same thing, which is why the guard checks token presence rather than the PR author.Trade-off: a secretless PR that touches these workflows merges without the dry run exercising the change. How fast that surfaces afterward differs by workflow:
coplanning-sync-fider-to-gh.ymlalso runs daily onschedule, so a break there shows up within a day;coplanning-sync-gh-to-fider.ymlhas onlypull_requestandworkflow_dispatchtriggers, so a break there waits for the next manual dispatch.The real-run steps (
workflow_dispatch/schedule) are untouched. The skip can't be reproduced locally or by dispatch (the guard only alterspull_requestbehavior); the next secretless PR touching these paths is the live validation.Additional information
The step-level
envblock mapssecrets.FIDER_TOKENintoFIDER_API_TOKENat the job level, and an unset secret renders as an empty string — which is exactly what the new condition tests.