Repository navigation
Conversation
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Already looking forward to the next diff. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Glavo
left a comment
Glavo
left a comment
There was a problem hiding this comment.
本审查建议由 GPT-5.6 Sol 生成
已将具体审查建议标注在对应代码行。
|
/@Glavo review |
Glavo
left a comment
Glavo
left a comment
There was a problem hiding this comment.
本审查建议由 GPT-5.6 Sol 生成
已将具体审查建议标注在对应代码行。
Glavo
left a comment
Glavo
left a comment
There was a problem hiding this comment.
本审查建议由 GPT-6 Astra 生成
已将具体审查建议标注在对应代码行。
There was a problem hiding this comment.
🟡 Changes recommended
Consuming all auto-hide events forces users to click other controls twice.
1 open finding
What changed in this PR
Adds reliable JFXPopup toggling and an animated close lifecycle.
Changes:
- Caches instance-management popups to support toggle-to-close behavior.
- Adds close animation, cancellation, event routing, and cleanup.
- Supports reopening and repositioning during close animations.
| File | Description |
|---|---|
GameListCell.java |
Reuses and toggles management popups. |
JFXPopupSkin.java |
Implements close animation and event handling. |
JFXPopup.java |
Integrates animated hiding and reopening. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Glavo
left a comment
Glavo
left a comment
There was a problem hiding this comment.
本审查建议由 GPT-6 Astra 生成
已将具体审查建议标注在对应代码行。
…g instance categories (HMCL-dev#6860)
Upstream HMCL HMCL-dev#6194 HMCL-dev#6860 HMCL-dev#6947 HMCL-dev#6747 HMCL-dev#6806 HMCL-dev#6407 HMCL-dev#6869 HMCL-dev#6825. Adapt JFXPopup and mod update logic to preserve existing fork features; retain crash diagnostics. Java CI and Check Codes passed; JAR/EXE/SH/DEB and nonempty credentials verified.
bandicam.2026-09-13.10-16-30-521.mp4
本PR的GameListCell是#6633 的延续，之前的PR没有修复三点按钮重复打开的问题