Repository navigation
feat(path): expose *Path-related utility functions - #349
Merged
uklotzde merged 18 commits intoOct 26, 2026
Merged
Conversation
cartercanedy
changed the title
*Path-related utility functions*Path-related utility functions
Contributor
Author
uklotzde
reviewed
Jul 30, 2026
uklotzde
left a comment
uklotzde
left a comment
Collaborator
There was a problem hiding this comment.
Thank you for your contribution and apologies for not responding promptly. Unfortunately we are currently very busy and didn't find the time for an in-depth review yet.
I left some initial comments.
Contributor
Author
|
Hey @uklotzde, sorry for the delay, should be good know |
cartercanedy
force-pushed
the
cc/implement-rel-path-methods
branch
from
October 5, 2026 12:39
fbdb195 to
aac0be3
Compare
Contributor
Author
|
@uklotzde thanks for fixing the precommit issues upstream, just rebased and everything's looking good |
uklotzde
reviewed
Oct 9, 2026
uklotzde
left a comment
uklotzde
left a comment
Collaborator
There was a problem hiding this comment.
Please also add a changelog entry.
Contributor
Author
|
Hey @uklotzde, are you available to rereview? |
cartercanedy
force-pushed
the
cc/implement-rel-path-methods
branch
from
October 14, 2026 14:17
9cdf958 to
1b1676c
Compare
cartercanedy
marked this pull request as draft
October 14, 2026 14:18
cartercanedy
force-pushed
the
cc/implement-rel-path-methods
branch
3 times, most recently
from
October 15, 2026 19:37
4bbc33c to
36e288c
Compare
cartercanedy
force-pushed
the
cc/implement-rel-path-methods
branch
3 times, most recently
from
October 20, 2026 12:43
a8c8971 to
a8b4178
Compare
cartercanedy
force-pushed
the
cc/implement-rel-path-methods
branch
2 times, most recently
from
October 22, 2026 03:57
402883d to
6b3fbeb
Compare
Collaborator
|
This PR does not need to be based on the ASAN PR. Code looks reasonable, just a changelog entry is missing. |
cartercanedy
force-pushed
the
cc/implement-rel-path-methods
branch
2 times, most recently
from
October 23, 2026 20:49
1fd1460 to
e5062a0
Compare
cartercanedy
marked this pull request as ready for review
October 23, 2026 20:51
cartercanedy
force-pushed
the
cc/implement-rel-path-methods
branch
from
October 23, 2026 20:53
e5062a0 to
4cce679
Compare
uklotzde
requested changes
Oct 26, 2026
uklotzde
left a comment
uklotzde
left a comment
Collaborator
There was a problem hiding this comment.
No objections regarding the code.
a summary entry in the changelog without details is IMHO sufficient.
uklotzde
previously approved these changes
Oct 26, 2026
uklotzde
left a comment
uklotzde
left a comment
Collaborator
There was a problem hiding this comment.
Thank you for your contributions! And patience ;)
uklotzde
reviewed
Oct 26, 2026
uklotzde
approved these changes
Oct 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #348
Implements
UA_RelativePathfactories/methods:UA_RelativePath_parse->ua::RelativePath::parse() -> Result<Self>UA_RelativePath_print->impl Display for ua::RelativePathget/get_mutthat folds the fallible access into the array validity checkiter/iter_mutthat also maps invalid array access to an empty iteratorIndex/IndexMutfor unsafe element accessAccesser methods were also implemented.
Note: rebased this onto the stack above #360 to unblock downstream work