Conversation
813dff3 to
4f9e49c
Compare
| 'bi_tag', | ||
| 'fast_app_target', | ||
| 'biTag', | ||
| 'fastAppTarget', |
There was a problem hiding this comment.
For the reviewer: Does this has to be "fast_app_target" or it can be "fastAppTarget"
I replaced "_" in every buildFields() method
|
@HMSPushKit @Mike-mei @rmibelgium Can anyone please review this PR? |
|
Hello @trbsi |
|
@Mike-mei |
HMSPushKit
left a comment
HMSPushKit
left a comment
There was a problem hiding this comment.
change function name could be accepted or fileName，but the attribute name can't be changed.
the include file has been verify in linux and windows, not need to change.
| @@ -0,0 +1,26 @@ | |||
| { | |||
There was a problem hiding this comment.
not used this php architecture since 3rd attribute
| @@ -0,0 +1,19 @@ | |||
| { | |||
| "php": ">=7.0" | ||
| }, | ||
| "platform-dev": [] | ||
| } |
| @@ -0,0 +1,151 @@ | |||
| <?php | |||
There was a problem hiding this comment.
Example/test_sample_push_topic_msg.php has it，not need it
| use push_admin\PushLogConfig; | ||
| namespace Huawei\Example\PushCommon; | ||
|
|
||
| use Huawei\PushNotifications\PushAdmin\AndroidConfigDeliveryPriority; |
There was a problem hiding this comment.
Where is “Huawei” Directory？
| @@ -18,19 +18,14 @@ | |||
| /** | |||
| * function: webpush message push control parameter, which is required for webpush msg=>PushMessage(webpush) | |||
| */ | |||
| namespace push_admin\push_msg\webpush; | |||
There was a problem hiding this comment.
include using has verify in linux and windows,not necessary to 'use'
| * =>PushMessage(webpush) | ||
| */ | ||
| namespace push_admin\push_msg\webpush; | ||
| namespace Huawei\PushNotifications\PushAdmin\PushMessage\WebPush; |
There was a problem hiding this comment.
include using has verify in linux and windows,not necessary to 'use'
| */ | ||
| namespace push_admin\push_msg\webpush; | ||
|
|
||
| namespace Huawei\PushNotifications\PushAdmin\PushMessage\WebPush; |
There was a problem hiding this comment.
include using has verify in linux and windows,not necessary to 'use'
| * =>PushMessage(webpush) | ||
| */ | ||
| namespace push_admin\push_msg\webpush; | ||
| namespace Huawei\PushNotifications\PushAdmin\PushMessage\WebPush; |
There was a problem hiding this comment.
include using has verify in linux and windows,not necessary to 'use'
|
|
||
| private $title; | ||
|
|
||
| private $icon; |
There was a problem hiding this comment.
include using has verify in linux and windows,not necessary to 'use'
3 participants
No description provided.