Repository navigation
fix(bootstrap): restore the SSH drop-in when sshd -t fails - #2
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bootstrap-server.sh used to stop on a failed
sshd -tbut left the broken drop-in on disk, so the next sshd restart would fail as well. The newinstall_sshd_dropinhelper backs up an existing drop-in, writes the new one, validates, and on failure restores the backup or removes the new file. Backup files are dot-files without a .conf suffix, so sshd's Include glob never picks them up.Tests: 3 new bats cases (pass, fail with no previous file, fail with a previous file) using a stub
SSHD_BIN. 24/24 locally, shellcheck clean. ADR 0002 updated to mark the gap resolved.