Skip to content

Update dependencies with new security advisories - #138

Merged
bermanto merged 1 commit into
mainfrom
fix/dependency-audit-advisories
Oct 10, 2026
Merged

bermanto merged 1 commit into
mainfrom
fix/dependency-audit-advisories

Conversation

@bermanto

@bermanto bermanto commented Oct 10, 2026 •

Copy link
Copy Markdown
Member

Summary

The Dependency audit workflow fails on main since the scheduled run on 2026-10-05. No code or
lockfile change caused this. Between 2026-09-18 and 2026-10-06, GitHub published 12 advisories
(1 critical, 5 high, 6 moderate) against packages in pnpm-lock.yaml.

Three of these packages have exact pins in the pnpm-workspace.yaml overrides: hono: 4.13.5,
fast-uri: 3.1.6, and ip-address: 10.3.1. These pins were security fixes from 2026-09-04 and
2026-09-12, but the new advisories now include the pinned versions. An update of the parent packages
cannot fix them while the pins stay.

Changes

  • pnpm-workspace.yaml: move the pins to patched versions: hono 4.13.13, fast-uri 3.1.8, and
    ip-address 10.7.3.
  • package.json: update @modelcontextprotocol/sdk from 1.29.0 to 1.32.1, and hono to
    ^4.13.13 to agree with the override.
  • pnpm-lock.yaml: refresh prosemirror-view (1.42.2 to 1.42.6), source-map-js (1.2.1 to
    1.2.2), and proxy-addr (2.0.7 to 2.0.8). This also moves some ProseMirror packages, browser data
    packages, @noble/hashes, and set-cookie-parser to newer patch versions.
  • CHANGELOG.md: add a "Fixed" entry under "Unreleased".

Exposure

I bundled the current Worker with wrangler deploy --dry-run --outdir and checked what it contains.

Package Advisories Exposure before this change
prosemirror-view 1 high: XSS in paste handling Real. It is in the composer bundle (rich-email-editor).
proxy-addr 1 critical None. It comes with express from the MCP SDK. The Worker does not bundle express.
@modelcontextprotocol/sdk 1 high None. The bug is in the OAuth client. HQBase uses only the server.
fast-uri 2 high, 1 moderate Low. ajv in the MCP SDK bundles it, but it reads only URIs in HQBase's own schemas.
source-map-js 1 high: DoS None found. postcss bundles it, but sanitize-html calls postcss with map: false.
ip-address 4 moderate None. The Worker does not bundle express-rate-limit.
hono 1 moderate: hono/jsx XSS None. HQBase does not use hono/jsx.

Checks

  • pnpm audit --prod --audit-level=moderate: no known vulnerabilities.
  • pnpm check: pass. 967 unit tests pass and 2 are skipped. 225 Worker integration tests pass.
  • pnpm deploy:dry-run: pass. The MCP SDK update makes the Worker upload about 240 KiB larger
    (about 46 KiB gzip).
  • No schema, API, or specification change.

Notes

  • Official HQBase staging E2E has not been run.
  • The audit is not a required check, so it does not block merges. Until this change merges, every
    pull request shows a failed audit.
  • Possible follow-up: use minimum versions (for example fast-uri: ^3.1.8) in place of exact pins.
    Then a normal pnpm update can pick up the next security patch.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Bug Fixes
    • Fixed an issue where unsafe content could be pasted into the message editor.
    • Updated security fixes for the MCP SDK, Hono, and other dependencies.

New advisories cover the exact hono, fast-uri, and ip-address override
pins, the MCP SDK, and transitive prosemirror-view, source-map-js, and
proxy-addr versions. Move each one to a patched version so the
dependency audit passes again.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 10, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: cdd759dd-3554-48d0-9b96-623b7b044a91

📥 Commits

Reviewing files that changed from the base of the PR and between 3244f06 and a3b5bbc.


⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml

📒 Files selected for processing (3)
  • CHANGELOG.md
  • package.json
  • pnpm-workspace.yaml

Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review.



📝 Walkthrough

Walkthrough

The pull request updates the MCP SDK, Hono, fast-uri, and ip-address versions. It also adds an Unreleased changelog entry describing dependency security updates, including a fix for unsafe content pasted into the message editor.

Changes

Dependency updates

Layer / File(s) Summary
Dependency versions and changelog
package.json, pnpm-workspace.yaml, CHANGELOG.md
package.json updates the MCP SDK and Hono versions. Workspace overrides update Hono, fast-uri, and ip-address. The Unreleased changelog records dependency security updates and a fix for unsafe pasted content in the message editor.

Priority: ⬆️ High

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Other


Merge Risk: ⚪ Minimal · up to a3b5b

No actionable risk introduced by this dependency update was identified; it appears mergeable with normal checks.

Pre-merge checks | Passed 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check Passed The title clearly summarizes the primary change: dependency updates made in response to security advisories.
Description check Passed The description provides a detailed summary, lists the changes, reports verification results, and includes notes. It uses a Checks section instead of the template's Verification heading and does not i…
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@socket-security

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updatedhono@​4.13.5 ⏵ 4.13.13100 +1100 +29796100
Updated@​modelcontextprotocol/​sdk@​1.29.0 ⏵ 1.32.199 +1100 +1610098100

View full report

@bermanto
bermanto merged commit 0f69bcf into main Oct 10, 2026
7 checks passed
@bermanto bermanto mentioned this pull request Oct 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant