Fixed an issue where an image skeleton is shown if the image url is null#336
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts the TraineeAvatar component rendering logic so that a missing/empty image URL doesn’t show the loading skeleton and instead falls back directly to a placeholder Avatar.
Changes:
- Return a fallback
AvatarwhenimageURLis falsy or when an image load error occurs. - Simplify the
<img>inline style by removing a redundant conditionaldisplayassignment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This comment has been minimized.
This comment has been minimized.
stasel
force-pushed
the
frontend/trainee-avatar-fix
branch
from
79c32c3 to
9381676
Compare
|
✅ Security Review — no issues found The PR modifies a single React component (
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Correct behavior is to show the default avatar image just like the on error
Before:
After:
