Fix event priority mismatch in LoadGlobalData. - #460
Merged
Conversation
Malkierian
reviewed
Aug 10, 2026
| // gameFile_load fires OnGameLoad. Restore them from global.json here before | ||
| // other OnGameLoad listeners read them. | ||
| REGISTER_LISTENER(OnGameLoad, EVENT_PRIORITY_HIGH, [](IEvent* event) { LoadGlobalData(); }); | ||
| REGISTER_LISTENER(OnGameLoad, EVENT_PRIORITY_LOW, [](IEvent* event) { LoadGlobalData(); }); |
Contributor
There was a problem hiding this comment.
Is this meant to be low, or is this a side effect of the inverted priority order you were talking about? If the latter, a note should be made to change it back when we fix that in LUS.
Contributor
Author
There was a problem hiding this comment.
Side effect. I would wait until we do LUS 2.0 migration to fix it though.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also fix SNS to use OnGameStart; the event priority mismatch had broken persistent bottles bonus.