fix(postgres): flatten multi-value _id predicates - #1417
Open
Gordex2014 wants to merge 1 commit into
Open
Gordex2014 wants to merge 1 commit into
Gordex2014 wants to merge 1 commit into
Conversation
Gordex2014
marked this pull request as ready for review
September 21, 2026 16:57
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1413.
What changed
_idfilters as a flat PostgreSQLINpredicate instead of a left-deepORtree._idand all_id:notbehavior unchanged._hasresolution produce positive_idfilters.Compatibility
Tenant and resource type scoping, placeholder offsets, repeated-parameter
ANDbehavior,_list,_include, and Bulk Export matching semantics are unchanged.Validation
search()andsearch_count()._has, wide two-level chain, single_id, and_id:nottests passed.Strict Clippy with
-D warningsremains blocked by existing Rust 1.97 warnings outside the changed code.Visual explanation
View the nested
ORversus flatINexplanation.Temporary review evidence expires
2026-09-26T16:55:00.190Z.Known limit
The query still uses one bind per ID. Lists near PostgreSQL's protocol limit of roughly 65,000 binds require a separate array-binding change.