Fix URL encoding of visual search condition values - #1420
Open
Gordex2014 wants to merge 1 commit into
Open
Gordex2014 wants to merge 1 commit into
Gordex2014 wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Entering
A&A HEALTHCARE LLCin a visual search condition previously generated a literal&, splitting the name into separate query parameters and returning unrelated records. The builder now producesGET /Location?name=A%26A%20HEALTHCARE%20LLCand returns the two matching Locations while excluding the control record.Encode each FHIR-serialized condition alternative during final URL assembly, before joining structural OR commas. Untouched loaded URLs keep their original spelling; visual edits rebuild correctly encoded values. Update manual testing matrix row 4.20.
Regression coverage checks actual requests and results on Queries and Resources, Copy/Saved/Recent, reload and deep links, reserved characters, typed values, escaped commas and OR alternatives, chains, and
_has. Validation passed with 128 browser tests, 60 unit tests, 3 focused Rust tests, and a UI build. The regression fails against the original implementation. Manual QA confirms both routes retain the literal value and return the intended records. Two independent reviews found no actionable issues.Closes #1415.
Before and after
The same visual condition now keeps the full name as one value. The query and narration are corrected, and the result count falls from three to two.
Temporary review evidence expires on 2026-10-21: before at
2026-10-21T17:24:55.225Z, after at2026-10-21T17:24:55.938Z.