Skip to content

fix(ui): group result counts by locale - #1432

Merged
smunini merged 1 commit into
mainfrom
feature/1426-locale-result-counts
Sep 22, 2026
Merged

smunini merged 1 commit into
mainfrom
feature/1426-locale-result-counts

Conversation

@Gordex2014

Copy link
Copy Markdown
Contributor

Closes #1426.

Summary

  • Format Resources result totals and included-resource counts with the active UI locale.
  • Preserve partial-total + wording and existing small and zero values.
  • Leave search requests, pagination, Bundle.total, and FHIR wire values unchanged.

Coverage

  • English: 12,345 results
  • Spanish: 12.345 resultados
  • German: 12.345 Ergebnisse
  • Grouped included count: 1,235 results · 1,234 included
  • Grouped partial count: 1,234+ results
  • Small and zero totals
  • Outgoing query remains the typed query plus the existing _total=accurate

Before and after

Before After
Resources results header showing ungrouped 12345 results Resources results header showing locale-grouped 12,345 results

Temporary review evidence expires 2026-09-26T21:17:00.786Z.

Checks

  • cargo test -p helios-ui
  • cargo build -p helios-hfs --features ui
  • Focused Chromium locale-count test
  • Chromium Resources and Queries suites: 124 passed
  • Independent review completed with no remaining findings

Risk

Low. The change only formats rendered count text through the browser's locale support.

@codecov

codecov Bot commented Sep 21, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@smunini
smunini merged commit 9ac153b into main Sep 22, 2026
25 checks passed
@smunini
smunini deleted the feature/1426-locale-result-counts branch September 22, 2026 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ui: group digits in Resources result counts according to locale

2 participants