Conversation
The US Core Observation ADI Documentation group has a SHALL patient + category + date search test. The example ADI documentation Observation had no effective[x], so the test could not find a date value and always skipped against the example bundle with "Could not find values for all search params `patient`, `category`, `date`". effective[x] is 0..1 and not must support in the profile, so the resource stays conformant. Use the same instant as issued, matching the neighbouring treatment intervention preference Observation.
Author
CI resultsRun in the Helios FHIR Server CI: the server is loaded with
The one skip on No other test changed result. The remaining failure is the Simple Observation multiple-or search from issue 43, fixed in #1. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The US Core Observation ADI Documentation group has a SHALL
patient + category + datesearch test. The example resourceObservation/usqualitycore-us-core-observation-adi-documentationhas noeffective[x], so the test cannot find adatevalue and always skips against the kit's own example bundle:It is the only skipped test when the
us_quality_core_v100_ballotsuite runs against a server loaded withclient-example-resources/us_quality_core_bundle_patient.json.Change
Add
"effectiveDateTime": "2024-05-16T01:06:06Z"to that Observation. It is the same instant as the resource'sissued, which is what the neighbouringusqualitycore-us-core-treatment-intervention-preferenceObservation does.Observation.effective[x]is0..1and not must support inus-core-observation-adi-documentation9.0.0, so the resource stays conformant and no must support expectations change.Testing
Run in the Helios FHIR Server CI, which loads the example bundle and runs the
us_quality_core_v100_ballotsuite withpatient_ids = usqualitycore-patient. Results to follow in a comment.