Skip to content

Add effectiveDateTime to the example ADI documentation Observation - #2

Open
smunini wants to merge 1 commit into
mainfrom
fix/adi-documentation-observation-effective
Open

smunini wants to merge 1 commit into
mainfrom
fix/adi-documentation-observation-effective

Conversation

@smunini

@smunini smunini commented Sep 20, 2026

Copy link
Copy Markdown

Summary

The US Core Observation ADI Documentation group has a SHALL patient + category + date search test. The example resource Observation/usqualitycore-us-core-observation-adi-documentation has no effective[x], so the test cannot find a date value and always skips against the kit's own example bundle:

Could not find values for all search params `patient`, `category`, `date`

It is the only skipped test when the us_quality_core_v100_ballot suite runs against a server loaded with client-example-resources/us_quality_core_bundle_patient.json.

Change

Add "effectiveDateTime": "2024-05-16T01:06:06Z" to that Observation. It is the same instant as the resource's issued, which is what the neighbouring usqualitycore-us-core-treatment-intervention-preference Observation does.

Observation.effective[x] is 0..1 and not must support in us-core-observation-adi-documentation 9.0.0, so the resource stays conformant and no must support expectations change.

Testing

Run in the Helios FHIR Server CI, which loads the example bundle and runs the us_quality_core_v100_ballot suite with patient_ids = usqualitycore-patient. Results to follow in a comment.

The US Core Observation ADI Documentation group has a SHALL
patient + category + date search test. The example ADI documentation
Observation had no effective[x], so the test could not find a date value
and always skipped against the example bundle with "Could not find
values for all search params `patient`, `category`, `date`".

effective[x] is 0..1 and not must support in the profile, so the
resource stays conformant. Use the same instant as issued, matching the
neighbouring treatment intervention preference Observation.
@smunini

smunini commented Sep 20, 2026

Copy link
Copy Markdown
Author

CI results

Run in the Helios FHIR Server CI: the server is loaded with client-example-resources/us_quality_core_bundle_patient.json, then the us_quality_core_v100_ballot suite runs with patient_ids = usqualitycore-patient (580 tests).

Test kit Result Run
v0.2.0 (41fc954) 578 pass / 1 skip / 1 fail, identical on 7 storage backends 35525950814
this branch (6e51b84) 579 pass / 0 skip / 1 fail 35536674380
this branch + #1 (4b8bc2b) 580 pass 35537188608, and 6 more backends in 35529459218

The one skip on v0.2.0 is us_core_observation_adi_documentation_patient_category_date_search_test. On this branch it runs and passes, including the comparator searches:

GET /Observation?category=observation-adi-documentation&date=2024-05-16T01:06:06Z&patient=usqualitycore-patient        -> 200
GET /Observation?category=observation-adi-documentation&date=gt2024-05-15T01:06:06+00:00&patient=usqualitycore-patient -> 200
GET /Observation?category=observation-adi-documentation&date=ge2024-05-15T01:06:06+00:00&patient=usqualitycore-patient -> 200
GET /Observation?category=observation-adi-documentation&date=lt2024-05-17T01:06:06+00:00&patient=usqualitycore-patient -> 200

No other test changed result. The remaining failure is the Simple Observation multiple-or search from issue 43, fixed in #1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant