Skip to content

The big patch #1 (background imgs, settings page, bug fixes, etc...)#74

Open
mkg20001 wants to merge 159 commits into
HelloZeroNet:masterfrom
ZeroNerds:patch-1
Open

The big patch #1 (background imgs, settings page, bug fixes, etc...)#74
mkg20001 wants to merge 159 commits into
HelloZeroNet:masterfrom
ZeroNerds:patch-1

Conversation

@mkg20001

@mkg20001 mkg20001 commented Apr 1, 2017

Copy link
Copy Markdown

Adds the ability to set a color and/or an image as background and a lot more features
Also there are other small fixes

@mkg20001

mkg20001 commented Apr 1, 2017

Copy link
Copy Markdown
Author

There is a weird bug.
After setting the background for the first time it's added to the non-optional files which causes signing to fail.
But after posting an image both files are added as optional files.
That's weird

@danimesq

danimesq commented Apr 1, 2017

Copy link
Copy Markdown
Contributor

Please show us a screenshot.

@mkg20001

mkg20001 commented Apr 1, 2017

Copy link
Copy Markdown
Author

1491066855
Here it is

@danimesq

danimesq commented Apr 1, 2017

Copy link
Copy Markdown
Contributor

Very welcome update!
Please say me what do you think about this update:
#66

@mkg20001

mkg20001 commented Apr 1, 2017

Copy link
Copy Markdown
Author

Nice

@danimesq

danimesq commented Apr 1, 2017

Copy link
Copy Markdown
Contributor

Can you try to add the profile covers feature?

@mkg20001

mkg20001 commented Apr 1, 2017

Copy link
Copy Markdown
Author

What do you mean exactly?

@danimesq

danimesq commented Apr 1, 2017

Copy link
Copy Markdown
Contributor

@mkg20001

mkg20001 commented Apr 1, 2017

Copy link
Copy Markdown
Author

Ok, but we already have a background image
We could add it but it would require a layout change

@danimesq

danimesq commented Apr 1, 2017

Copy link
Copy Markdown
Contributor

The background image the others can see in the profile, or it is only for the user?
My proposal about covers is the made it public in the profiles.

@mkg20001

mkg20001 commented Apr 1, 2017

Copy link
Copy Markdown
Author

It is public

@mkg20001

mkg20001 commented Apr 1, 2017

Copy link
Copy Markdown
Author

@danimesq

danimesq commented Apr 1, 2017

Copy link
Copy Markdown
Contributor

Some updates working in background (but no messages about it), with patience now its working.

@mkg20001 mkg20001 changed the title Add background images and colors Add background images and other stuff Apr 2, 2017
@mkg20001

mkg20001 commented Apr 2, 2017

Copy link
Copy Markdown
Author
  • Make other user's background optional
  • Add ability to disable background features
  • Add ability to disable background on feed
  • Add white background to sidebar
  • Improve default background and color
  • Make the background image an optional file
  • Add permalink to date
  • Fix permalinks for comments

@danimesq

Copy link
Copy Markdown
Contributor

@shortcutme, can you review it?

@mkg20001

Copy link
Copy Markdown
Author

@Plasmmer I added the 2 column view, but currently it's very buggy.

@danimesq

danimesq commented Apr 16, 2017

Copy link
Copy Markdown
Contributor

I added the 2 column view, but currently it's very buggy.

Reference: ZeroNerds#97.

@mkg20001

mkg20001 commented May 6, 2017

Copy link
Copy Markdown
Author

@HelloZeroNet Could you review please?

@HelloZeroNet

HelloZeroNet commented May 7, 2017

Copy link
Copy Markdown
Owner

Thanks it has lots of great modifications! I prefer the current, simplier design, so maybe it would be better to allow people to choose between the two merger sites.
Right now I working on a site that is showcases user created content on ZeroNet instead of current welcome page, so it will make it easer to find new sites.
What do you think?

@mkg20001

mkg20001 commented May 7, 2017

Copy link
Copy Markdown
Author

Great idea!
But there should be a way for the community and not just a single person to determine what should be showcased.

@danimesq

danimesq commented May 7, 2017

Copy link
Copy Markdown
Contributor

It can be a page with all items and upvote buttons,, and in top the most upvoted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants