Merged
Conversation
### Added - `Measure-BasicWebRequestProperty`: Detects when `Invoke-WebRequest` uses `UseBasicParsing` with incompatible properties like `Forms`, `ParsedHtml`, `Scripts`, or `AllElements`. Works with both direct property access and variable assignments. - `Measure-InvokeWebRequestWithoutBasic`: Flags `Invoke-WebRequest` (and its aliases `iwr`, `curl`) when used without the `UseBasicParsing` parameter. - `Get-CommandParameter`: New private helper function to parse command parameters from AST, including support for positional parameters. - Documentation for new rules in `docs/en-US/` directory. - Comprehensive test coverage for new rules. ### Changed - Updated `about_GoodEnoughRules.help.md` with complete module documentation including examples, rule descriptions, and troubleshooting guidance. - `Measure-SecureStringWithKey`: Standardized parameter block formatting and updated to use `Get-CommandParameter` helper function. - Test files: Added BeforeAll checks to ensure module builds before testing. - Improved code consistency across all rule files (param block formatting, using consistent helper function names).
* Added `contents: read` and `issues: write` permissions to enhance workflow capabilities.
Test Results 3 files 57 suites 2s ⏱️ Results for commit 7609530. ♻️ This comment has been updated with latest results. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added
Measure-BasicWebRequestProperty: Detects whenInvoke-WebRequestusesUseBasicParsingwith incompatible properties likeForms,ParsedHtml,Scripts, orAllElements. Works with both direct property access and variable assignments.Measure-InvokeWebRequestWithoutBasic: FlagsInvoke-WebRequest(and its aliasesiwr,curl) when used without theUseBasicParsingparameter.Get-CommandParameter: New private helper function to parse command parameters from AST, including support for positional parameters.docs/en-US/directory.Changed
about_GoodEnoughRules.help.mdwith complete module documentation including examples, rule descriptions, and troubleshooting guidance.Measure-SecureStringWithKey: Standardized parameter block formatting and updated to useGet-CommandParameterhelper function.