CORS policy: Response to preflight request doesn't pass access co... - #3530
Open
harshvardhan60792 wants to merge 1 commit into
Open
Conversation
Self-hosted S3-compatible bucket had no CORS policy after deployment, so browser uploads via presigned URLs failed preflight; s3-init now applies a permissive CORS policy right after creating the bucket, matching the workaround from the issue.
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3379
Self-hosted S3-compatible bucket had no CORS policy after deployment, so browser uploads via presigned URLs failed preflight; s3-init now applies a permissive CORS policy right after creating the bucket, matching the workaround from the issue.
Testing: No JS/TS test suite applies to this docker-compose/shell change; validated narrowly by running only the s3 + s3-init services in isolation (not the full stack) and confirming via aws s3api get-bucket-cors and the exact OPTIONS preflight curl from the issue that access-control-allow-origin/methods/headers/max-age now come back, whereas the pre-fix s3-init left the bucket with no CORS config.