Skip to content

Retry invalid terminal reflection repairs - #43

Merged
HhhBZzz merged 1 commit into
codex/bootstrap-githubfrom
codex/memory-reflection-harness-repair
Jul 1, 2026
Merged

Retry invalid terminal reflection repairs#43
HhhBZzz merged 1 commit into
codex/bootstrap-githubfrom
codex/memory-reflection-harness-repair

Conversation

@HhhBZzz

@HhhBZzz HhhBZzz commented Jul 1, 2026

Copy link
Copy Markdown
Owner

Summary

  • Do not accept terminal reflection results that only cite the run without an event-level evidence reference.
  • Retry when the first semantic repair still returns invalid reflection content, especially empty lesson.
  • Update the initial/refinement prompts so provider-backed reflection no longer encourages empty lessons.

Test Plan

  • mvn -q -Dtest=ProviderBackedTerminalReflectionGeneratorTest test
  • mvn -q -Dtest=ProviderBackedTerminalReflectionGeneratorTest,TerminalMemoryExtractionServiceTest,MemoryProviderEvaluationHarnessServiceTest,MemoryExtractionTriggerTest,RuntimeMemoryEvaluationControllerTest,RuntimeMemoryCandidateControllerTest,MemoryCandidateReviewServiceTest test
  • git diff --check

Context

After PR #42, local provider harness improved evidence grounding but still failed terminal reflection when the provider returned an empty lesson with valid evidence. This PR covers and repairs that second invalid-output mode.

@HhhBZzz
HhhBZzz merged commit 66d561b into codex/bootstrap-github Jul 1, 2026
1 check passed
HhhBZzz added a commit that referenced this pull request Aug 5, 2026
…epair

Retry invalid terminal reflection repairs
@HhhBZzz
HhhBZzz deleted the codex/memory-reflection-harness-repair branch August 5, 2026 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant