Bump jsoncons to latest release#78
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #78 +/- ##
==========================================
- Coverage 98.08% 97.93% -0.15%
==========================================
Files 20 20
Lines 1359 1359
Branches 885 887 +2
==========================================
- Hits 1333 1331 -2
Misses 5 5
- Partials 21 23 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
0f4b52b to
9f80e22
Compare
9f80e22 to
873e6a7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bumps the
danielaparker/jsonconsdependency from v1.4.3 to v1.8.1, andincludes the source/CI changes needed to keep the build and the RISC-V test
passing with the newer release.
Changes
Dependency
jsonconsGIT_TAGfromv1.4.3→v1.8.1. - src/Parser.cpp: adapt to the updated jsoncons JSON-schema API — callschema.validate(doc)directly instead of capturing the now-unneeded[[maybe_unused]] auto statusreturn value. Validation failures are still reported via thevalidation_errorcatch.Multicast monitor thread-safety
terminateflag from a plainbooltostd::atomic<bool>(adding#include <atomic>), and update thecommit_listener/home_node_listenersignatures to takeconst std::atomic<bool> *terminate. This removes a data race on the sharedtermination flag. - Make the listener
recvfromnon-blocking (MSG_DONTWAIT) so the loop can observe the terminate flag instead of blocking indefinitely.pthread_cancel+ unconditionaljointeardown with settingterminate = trueand joining only when the threads arejoinable(), giving a clean, deterministic shutdown. Fixes hangs observed under RISC-V emulation.CI (RISC-V python bindings)
run-on-arch-actionriscv64 distro toubuntu22.04(wasubuntu_latest) for a stable image;pytest-timeout==2.4.0.