🧪 [testing improvement] Add unit tests for generateReadmeUrl function

[is0692vs]

🎯 What:
Added unit tests for the generateReadmeUrl function in src/components/ReadmeCardUrlSection.tsx, which was completely untested. This is a pure function that generates README URL strings based on inputs like username, themes, layouts, and display options. Also included UI tests for the ReadmeCardUrlSection component.

📊 Coverage:

• generateReadmeUrl: Tested base cases, edge cases (like username = undefined), proper serialization of the hide parameter (stars, forks, or both), dynamic inclusions (streak, heatmap), and custom layout processing.
• ReadmeCardUrlSection: Covered UI interactions including state updates (changing checkboxes/selects and ensuring URL updates correctly), clipboard interactions (navigator.clipboard.writeText) handling both success and failure cases, and fallback rendering behavior.

✨ Result:
100% statement, branch, function, and line coverage achieved for src/components/ReadmeCardUrlSection.tsx. Improved confidence in formatting rules when refactoring layout and display options logic.

---

PR created automatically by Jules for task 6281433727673307851 started by @is0692vs

Greptile Summary

generateReadmeUrl および ReadmeCardUrlSection コンポーネントのテストを全面リファクタリングし、vitest.config.ts のカバレッジ対象にも追加しています。テスト構造は概ね改善されていますが、1 件の P1 問題があります：

• テスト "should return default blocks when layout is empty but includeStreak is true" は名前と異なり includeStreak: false で実行されており、「空レイアウト + streak 有効」時の挙動（blocks=streak）が一切テストされていません。

Confidence Score: 4/5

P1 のテスト名・実装不一致を修正すればマージ可能

テスト名が「includeStreak: true」と述べているにもかかわらず実際には false で動作しており、空レイアウト + streak 有効というコードパスが未テストのまま。この P1 問題を解消するまでスコアを 5 にはできない。残りの指摘は P2 のスタイル・整理系。

src/components/tests/ReadmeCardUrlSection.test.tsx の130行目付近のテストケース

Important Files Changed

Filename	Overview
src/components/tests/ReadmeCardUrlSection.test.tsx	テストスイートを全面リファクタリング。テスト名と実装が不一致な箇所があり未カバーのコードパスが残る。Object.assign によるモック後始末の不備あり。
vitest.config.ts	カバレッジ対象に ReadmeCardUrlSection.tsx を追加。変更は最小限で問題なし。
pr_description.md	PR 説明文が誤ってリポジトリにコミットされたファイル。ソースコードとして追跡する必要はない。

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[generateReadmeUrl] --> B{username が存在するか?}
    B -- No --> C[空文字列を返す]
    B -- Yes --> D[visible なブロックをフィルタリング]
    D --> E[blockMap でターゲット名に変換]
    E --> F[selectedBlocks を構築]
    F --> G{includeStreak?}
    G -- Yes --> H[streak を追加]
    G -- No --> I
    H --> I{includeHeatmap?}
    I -- Yes --> J[heatmap を追加]
    I -- No --> K
    J --> K[重複を除去: uniqueBlocks]
    K --> L{uniqueBlocks.length > 0?}
    L -- Yes --> M[blocks = uniqueBlocks.join]
    L -- No --> N[blocks = bio,stats,langs フォールバック]
    M --> O[URL を組み立て返却]
    N --> O

Loading

Prompt To Fix All With AI

This is a comment left during a code review.
Path: src/components/__tests__/ReadmeCardUrlSection.test.tsx
Line: 130-140

Comment:
**テスト名と実装が一致していない（未テストのコードパスが残る）**

テスト名は `"…but includeStreak is true"` と述べているにもかかわらず、テスト本体は `...defaultProps` をそのまま展開しており `includeStreak` は `false` のままです。そのため、このテストが実際に検証しているのは「空レイアウト + `includeStreak: false` → フォールバック `"bio,stats,langs"`」です。

「空レイアウト + `includeStreak: true`」の場合、ソースの実装では `uniqueBlocks = ["streak"]`（length > 0）となり、`blocks` は `"streak"` になります（フォールバックには入りません）。この挙動は現在どのテストでもカバーされていません。

修正案として、テストを 2 つに分ける方法が明確です。

```suggestion
  it("should return default blocks when layout is empty and includeStreak is false", () => {
    const layout: CardLayout = {
      blocks: [],
    };
    const url = generateReadmeUrl({
      ...defaultProps,
      layout,
    });
    const parsedUrl = new URL(url);
    expect(parsedUrl.searchParams.get("blocks")).toBe("bio,stats,langs");
  });

  it("should include streak in blocks when layout is empty but includeStreak is true", () => {
    const layout: CardLayout = {
      blocks: [],
    };
    const url = generateReadmeUrl({
      ...defaultProps,
      layout,
      includeStreak: true,
    });
    const parsedUrl = new URL(url);
    expect(parsedUrl.searchParams.get("blocks")).toBe("streak");
  });
```

How can I resolve this? If you propose a fix, please make it concise.

---

This is a comment left during a code review.
Path: src/components/__tests__/ReadmeCardUrlSection.test.tsx
Line: 163-169

Comment:
**`Object.assign` によるモックは `afterEach` で復元されない**

`beforeEach` で `Object.assign(navigator, { clipboard: ... })` を使って `navigator.clipboard` を直接置き換えています。`afterEach` の `vi.restoreAllMocks()` は `vi.spyOn` で作成したスパイのみを復元し、`Object.assign` による変更は元に戻しません。`navigator.clipboard` は jsdom 環境内で汚染されたままになります。

元の実装のように `vi.stubGlobal` を使えば `vi.unstubAllGlobals()` で確実にクリーンアップできます。

```suggestion
  beforeEach(() => {
    vi.stubGlobal("navigator", {
      ...globalThis.navigator,
      clipboard: {
        writeText: vi.fn().mockResolvedValue(undefined),
      },
    });
  });

  afterEach(() => {
    vi.unstubAllGlobals();
    vi.restoreAllMocks();
  });
```

How can I resolve this? If you propose a fix, please make it concise.

---

This is a comment left during a code review.
Path: pr_description.md
Line: 1-9

Comment:
**`pr_description.md` をリポジトリにコミットすべきではない**

このファイルは PR 説明文として自動生成されたものであり、ソースコードとして追跡する必要はありません。リポジトリのルートに残すと、将来的に混乱の原因になります。`.gitignore` への追加か、ファイル自体の削除を検討してください。

How can I resolve this? If you propose a fix, please make it concise.

---

This is a comment left during a code review.
Path: src/components/__tests__/ReadmeCardUrlSection.test.tsx
Line: 175-180

Comment:
**`@testing-library/jest-dom` の削除により DOM アサーションが弱くなっている**

旧実装では `toBeInTheDocument()` を使い、要素が実際に DOM 内に存在することを明示的に検証していましたが、今回 `@testing-library/jest-dom` の import が削除され `toBeTruthy()` に置き換わっています。`getByText` が例外をスローするため機能的に問題はありませんが、`toBeTruthy()` は `null` 以外のあらゆる値を通過させるため意図が伝わりにくくなります。`@testing-library/jest-dom` を再度 import して `toBeInTheDocument()` を使う方が可読性・意図が明確になります。

How can I resolve this? If you propose a fix, please make it concise.

_{Reviews (1): Last reviewed commit: "🧪 Add unit tests for generateReadmeUrl ..." | Re-trigger Greptile}

Greptile also left 4 inline comments on this PR.

[google-labs-jules]

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.

---

For security, I will only act on instructions from the user who triggered this task.

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
github-user-summary	Ready	Preview, Comment	Apr 17, 2026 8:39am

[coderabbitai]

Warning

Rate limit exceeded

@is0692vs has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 21 minutes and 22 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 21 minutes and 22 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 8b8d5a5e-a7bf-4bed-832d-6d65d9f277ce

📥 Commits

Reviewing files that changed from the base of the PR and between 3be157d and 34df053.

📒 Files selected for processing (3)

• pr_description.md
• src/components/__tests__/ReadmeCardUrlSection.test.tsx
• vitest.config.ts

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch test-generate-readme-url-6281433727673307851

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

[gemini-code-assist]

Code Review

This pull request introduces comprehensive unit and UI tests for the generateReadmeUrl function and the ReadmeCardUrlSection component, achieving 100% code coverage. The feedback identifies a regression in test quality due to the removal of userEvent and jest-dom matchers, a misleading test description regarding default blocks, and the use of non-idiomatic global mocking techniques that could lead to state leakage between tests.