Skip to content

🧹 [Code Health] Remove explicit @ts-expect-error in cardLayout tests #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
is0692vs wants to merge 2 commits into
base: main
Choose a base branch
from
+3 −4
Open

🧹 [Code Health] Remove explicit @ts-expect-error in cardLayout tests #175

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
11ad5c5
🧹 [Code Health] Remove explicit @ts-expect-error in cardLayout tests
google-labs-jules[bot] Apr 17, 2026
4f47e0e
🧹 [Code Health] Remove explicit @ts-expect-error in cardLayout tests
google-labs-jules[bot] Apr 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions src/lib/__tests__/cardLayout.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import {
normalizeCardLayout,
toggleBlockVisibility,
} from "../cardLayout";
import { DEFAULT_CARD_LAYOUT } from "../types";
import { CardBlockId, DEFAULT_CARD_LAYOUT } from "../types";
Comment thread
is0692vs marked this conversation as resolved.

describe("cardLayout utilities", () => {
describe("cloneDefaultCardLayout", () => {
Expand Down Expand Up @@ -78,7 +78,7 @@ describe("toggleBlockVisibility", () => {
const layout = cloneDefaultCardLayout();
// Use unknown block ID
// We have to cast to unknown -> CardBlockId here because TS would complain
const next = toggleBlockVisibility(layout, "nonExistent" as unknown as import("../types").CardBlockId);
const next = toggleBlockVisibility(layout, "nonExistent" as unknown as CardBlockId);
Comment thread
is0692vs marked this conversation as resolved.

expect(next.blocks).toEqual(layout.blocks);
});
Expand All @@ -105,8 +105,7 @@ describe("toggleBlockVisibility", () => {

it("moveBlock returns original layout when moving non-existent block", () => {
const layout = cloneDefaultCardLayout();
// @ts-expect-error Testing invalid block ID
const moved = moveBlock(layout, "nonExistentBlock", "left", 0);
const moved = moveBlock(layout, "nonExistentBlock" as unknown as CardBlockId, "left", 0);
Comment thread
is0692vs marked this conversation as resolved.
Comment thread
is0692vs marked this conversation as resolved.

expect(moved).toBe(layout);
});
Expand Down
Loading