Skip to content

docs(environments): describe the Linux sleep inhibitor as it now runs - #6373

Merged
Hmbown merged 1 commit into
mainfrom
claude/trusting-shannon-sgusdh
Sep 21, 2026
Merged

Hmbown merged 1 commit into
mainfrom
claude/trusting-shannon-sgusdh

Conversation

@Hmbown

@Hmbown Hmbown commented Sep 21, 2026

Copy link
Copy Markdown
Owner

Summary

Devin's analysis note on #6372: docs/ENVIRONMENTS.md still showed the Linux inhibitor as systemd-inhibit … sleep infinity, while since #6372 the command is cat reading a pipe the guard holds and the release is that pipe closing. The guide now says so, and states that nothing is left behind.

No-Issue: docs follow-up to #6372's review note; one line of the environment guide.

Testing

Docs only; no code or generated file changes. CI's light-change path covers the markdown checks.

  • cargo fmt --all -- --check (n/a, no Rust changes)
  • cargo clippy --workspace --all-targets --all-features --locked (n/a)
  • cargo test --workspace --all-features --locked (n/a)

Checklist

  • This PR adds a new layer/module/abstraction — it names or deletes the layer it replaces (n/a)
  • Updated docs or comments as needed
  • Added or updated tests where relevant (n/a)
  • Verified TUI behavior manually if UI changes (n/a)
  • Harvested/co-authored credit uses a GitHub numeric noreply address (n/a)

🤖 Generated with Claude Code

https://claude.ai/code/session_0134iUMxmGuXiG1LzPgfZVnv


Generated by Claude Code

#6372 replaced the inhibitor's `sleep infinity` with `cat` on a pipe the
guard holds, so the release is the pipe closing rather than a signal; the
environment guide still showed the old command.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0134iUMxmGuXiG1LzPgfZVnv
@Hmbown
Hmbown marked this pull request as ready for review September 21, 2026 03:08
Copilot AI lite review requested due to automatic review settings September 21, 2026 03:08

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@Hmbown
Hmbown merged commit 2a98f0d into main Sep 21, 2026
31 of 33 checks passed
@Hmbown
Hmbown deleted the claude/trusting-shannon-sgusdh branch September 21, 2026 03:08
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 21, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-21T03:10:09.463206Z c6a7075 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@claude

claude Bot commented Sep 21, 2026 •

Copy link
Copy Markdown
Contributor

Claude finished @Hmbown's task in 42s —— View job


Review: docs(environments) — Linux sleep inhibitor description

  • Gather context (PR diff, docs/ENVIRONMENTS.md, crates/tui/src/sleep_guard.rs)
  • Verify the doc change against the actual implementation
  • Post findings

Summary

This is a documentation-only fix (+5/-3, single file) correcting docs/ENVIRONMENTS.md to match the Linux sleep-inhibitor implementation that shipped in #6372.

I cross-checked the updated text against crates/tui/src/sleep_guard.rs:

  • The command is accurately described: systemd-inhibit --what=idle --why="Codewhale turn in flight" --mode=block cat, matching start_inhibitor() (sleep_guard.rs:106-117).
  • The explanation that cat reads a pipe held by the guard, and that dropping the guard closes the pipe so cat exits on EOF and systemd-inhibit follows, matches both the module doc comment (sleep_guard.rs:36-39) and the spawn() implementation (stdin piped, never written to; kill_on_drop(true)).
  • The claim "nothing is left behind" is backed by the existing test a_released_guard_leaves_no_grandchild_behind (sleep_guard.rs:188-214), which explicitly checks that grandchild processes don't outlive the guard.
  • Surrounding scope statements (idle-only assertion, headless hosts never hold it, Windows unimplemented and why) are unchanged and remain consistent with the module's stated scope (sleep_guard.rs:10-25).

No correctness, provider/model-routing, reuse, test-coverage, or security concerns — this only touches prose in a markdown file. No code changes to review. I don't have anything to flag here; the update accurately reflects current behavior.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Devin Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants