Make the symmetric heuristic start scale-covariant - #53
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #53 +/- ##
=======================================
Coverage 98.91% 98.92%
=======================================
Files 15 15
Lines 3785 3805 +20
=======================================
+ Hits 3744 3764 +20
Misses 41 41 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
The unconstrained AbsLog{2} start for symcover now fits the diagonally
normalized entries |A_ij|/sqrt(|A_ii A_jj|) and rescales by sqrt|A_ii|.
The start, and hence the whole heuristic, is scale-covariant whenever
every component of the support contains a nonzero diagonal entry.
Assisted-by: Claude Fable 5.1 <noreply@anthropic.com>
The :leaveout initializer now reruns the unconstrained AbsLog{2} kernel
with the dropped entry excluded from the support iterator, instead of
polishing the full-support start with Gauss-Seidel sweeps. Excluding
the entry also removes it from the diagonal reference, so a dropped
diagonal entry's row takes its reference from its neighbors, and the
start equals the :geomean start of the matrix with that entry zeroed.
Assisted-by: Claude Fable 5.1 <noreply@anthropic.com>
timholy
force-pushed
the
teh/covariant-sym-init
branch
from
September 4, 2026 09:52
65f5580 to
71a3c4c
Compare
The count of inner solves on the dense exact path varies by a few across machines with BLAS roundoff; on one CI runner the symmetric 60x60 case took 35. Give the symmetric bound the same kind of margin the nonsymmetric bound already has. Assisted-by: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The unconstrained AbsLog{2} start for symcover now fits the diagonally normalized entries |A_ij|/sqrt(|A_ii A_jj|) and rescales by sqrt|A_ii|. The start, and hence the whole heuristic, is scale-covariant whenever every component of the support contains a nonzero diagonal entry.
Assisted-by: Claude Fable 5.1 noreply@anthropic.com