Conversation
- Add SparseCholesky with a concretely typed CHOLMOD workspace to bypass dynamic dispatch through task-local storage. Use it for Woodbury and LSQR, reusing solve workspaces. - Remove boxed captures and abstract factorization storage, and use a shared row/column index type in flat_support. - Use fixed-arity eachindex checks and direct SparseMatrixCSC construction to avoid statically unresolvable calls. Relax the LSQR allocation ratio bound: reduced per-solve overhead exposes superlinear preconditioner fill. Assisted-by: Claude Fable 5.1 <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #55 +/- ##
==========================================
- Coverage 98.94% 98.94% -0.01%
==========================================
Files 15 16 +1
Lines 3900 4060 +160
==========================================
+ Hits 3859 4017 +158
- Misses 41 43 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relax the LSQR allocation ratio bound: reduced per-solve overhead exposes superlinear preconditioner fill.
Assisted-by: Claude Fable 5.1 noreply@anthropic.com