Skip to content

Fix ≻ and ⪰ to compare the correct endpoints #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
timholy merged 1 commit into from
Sep 5, 2026
Merged

Fix ≻ and ⪰ to compare the correct endpoints #23

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name = "ThickNumbers"
uuid = "b57aa878-5b76-4266-befc-f8e007760995"
authors = ["Tim Holy <tim.holy@gmail.com> and contributors"]
version = "1.1.2"
version = "1.1.3"

[deps]
LinearAlgebra = "37e2e46d-f89d-539d-b4ee-838fcccc9c8e"
Expand Down
6 changes: 3 additions & 3 deletions src/ThickNumbers.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -406,7 +406,7 @@ const ⪾ = is_strict_supset_tn
"""
isempty(x::ThickNumber)

Returns `true` if `hival(x) < loval(x)` is empty, `false` otherwise.
Returns `true` if the span of `x` is empty (`hival(x) < loval(x)`), `false` otherwise.
"""
Base.isempty(x::ThickNumber) = hival(x) < loval(x)

Expand Down Expand Up @@ -516,7 +516,7 @@ Base.:(<)(::ThickNumber, ::ThickNumber) = throw(FPTNException(<, "≺ (\\prec-TA

Returns `true` if `loval(a) > hival(b)`, `false` otherwise. Use `\\succ`-TAB to type.
"""
≻(a::ThickNumber, b::ThickNumber) = hival(a) > loval(b)
≻(a::ThickNumber, b::ThickNumber) = loval(a) > hival(b)
Base.:(>)(::ThickNumber, ::ThickNumber) = throw(FPTNException(>, "≻ (\\succ-TAB)"))

"""
Expand All @@ -532,7 +532,7 @@ Base.:(<=)(::ThickNumber, ::ThickNumber) = throw(FPTNException(<=, "⪯ (\\prece

Returns `true` if `loval(a) ≥ hival(b)`, `false` otherwise. Use `\\succeq`-TAB to type.
"""
⪰(a::ThickNumber, b::ThickNumber) = hival(a) >= loval(b)
⪰(a::ThickNumber, b::ThickNumber) = loval(a) >= hival(b)
Base.:(>=)(::ThickNumber, ::ThickNumber) = throw(FPTNException(>=, "⪰ (\\succeq-TAB)"))


Expand Down
5 changes: 5 additions & 0 deletions test/runtests.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,11 @@ using MidRadArith
@test !isless_tn(Interval(1, 2), 2)
@test Interval(1, 2) ⪯ Interval(2, 3)
@test Interval(2, 3) ⪰ Interval(1, 2)
# Overlapping spans are unordered.
@test !(Interval(2, 4) ≻ Interval(1, 3))
@test !(Interval(1, 3) ≺ Interval(2, 4))
@test !(Interval(2, 4) ⪰ Interval(1, 3))
@test !(Interval(1, 3) ⪯ Interval(2, 4))
@test issubset_tn(Interval(1, 2), Interval(1, 2))
@test Interval(1, 2) ⫃ Interval(1, 2)
@test_throws FPTNException issubset(Interval(1, 2), Interval(1, 2))
Expand Down
Loading