Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR migrates the repository’s Ruby test suite from Minitest to RSpec to align with Homebrew org standards, updates CI to run the new spec task, and introduces Bundler-managed dependencies for consistent local/CI execution.
Changes:
- Replaced the Minitest test suite with an RSpec spec suite (including fixture relocation).
- Added Bundler files (
Gemfile,Gemfile.lock) and RSpec configuration (.rspec,spec/spec_helper.rb). - Updated Rake and GitHub Actions workflows to run
bundle exec rake spec(andbundle exec rake repology:buildwhere applicable) withbundler-cache: true.
Reviewed changes
Copilot reviewed 9 out of 13 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| test/test_helper.rb | Removed Minitest shared helper (no longer needed after migration). |
| test/repology_index_test.rb | Removed Minitest coverage for RepologyIndex (replaced by RSpec). |
| spec/spec_helper.rb | Added shared RSpec helpers and configuration (fixtures, load path, ordering). |
| spec/repology_index_spec.rb | Added RSpec port of the prior Minitest suite for RepologyIndex. |
| spec/fixtures/repology_page1.json | Added fixture data under spec/fixtures/ for RSpec suite. |
| spec/fixtures/repology_page2.json | Added fixture data under spec/fixtures/ for RSpec suite. |
| Rakefile | Switched from rake test task to rake spec via RSpec::Core::RakeTask. |
| Gemfile | Added Bundler dependencies for rake and rspec. |
| Gemfile.lock | Locked dependency versions for consistent installs. |
| .rspec | Configured RSpec to require spec_helper. |
| .gitignore | Ignored Bundler install/cache directories. |
| .github/workflows/validate.yml | Updated CI to use Bundler cache and run bundle exec rake spec. |
| .github/workflows/regenerate.yml | Updated scheduled workflow to use Bundler cache and run spec + repology build via Bundler. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up from #30 (comment) — the rest of the Homebrew org standardised on RSpec, so bring this repo in line.
spec/repology_index_spec.rbis a 1:1 port oftest/repology_index_test.rb(30 examples), grouped intodescribeblocks per method.ScriptedIndexbecomes an anonymousClass.new(described_class)in aletso it doesn't leak a top-level constant. Fixtures move tospec/fixtures/unchanged.Adds a
Gemfile(rake+rspec);Homebrew/actions/setup-rubyalready runsbundle installwhen one is present, so both workflows just gainbundler-cache: trueand switchrake test→bundle exec rake spec.dependabot.ymlis org-synced so no bundler ecosystem entry is added here.#30 adds
test/advisory_index_test.rb; whichever of these merges second will need a small follow-up to convert or add that file underspec/.