Skip empty upgrade ask prompt#22333
Merged
Merged
Conversation
- Avoid prompting for `brew upgrade --ask` when the dry-run plan has no version changes. - Keep the ask-flow regression explicit so the prompt still appears when there are upgrades.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates brew upgrade --ask so it only prompts for confirmation when the dry-run upgrade summary contains actual version changes.
Changes:
- Gates the upgrade confirmation prompt on
final_upgrade_summary.version_changes. - Updates ask-flow tests to cover both upgrade-present and no-upgrade cases.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
Library/Homebrew/cmd/upgrade.rb |
Skips Install.ask when the dry-run plan has no upgrade version changes. |
Library/Homebrew/test/cmd/upgrade_spec.rb |
Adjusts and adds regression tests for --ask prompt behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
SMillerDev
approved these changes
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
brew upgrade --askwhen the dry-run plan has no version changes.brew lgtm(style, typechecking and tests) with your changes locally?OpenAI Codex 5.5 xhigh with manual review and testing.