allow data attributes to override defaults#178
Open
fauxparse wants to merge 1 commit intoHubSpot:masterfrom
Open
allow data attributes to override defaults#178fauxparse wants to merge 1 commit intoHubSpot:masterfrom
fauxparse wants to merge 1 commit intoHubSpot:masterfrom
Conversation
The commit in e609ba0 broke the ability to use data attributes to override the position and onOpen options, since these are always set as defaults.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The commit in e609ba0 broke
the ability to use data attributes to override the position
and onOpen options, since these are always set as defaults.