(Not yet upstreamed) HBASE-29895: BackupBoundaries global coverage can allow premature WAL deletion when backup roots have different host coverage - #259
Merged
Conversation
… deletion when backup roots have different host coverage
hgromer
commented
Aug 17, 2026
| import static org.junit.jupiter.api.Assertions.assertNotNull; | ||
| import static org.junit.jupiter.api.Assertions.assertNotSame; | ||
| import static org.junit.jupiter.api.Assertions.fail; | ||
|
|
Collaborator
Author
There was a problem hiding this comment.
Just ran spotless apply
hgromer
commented
Aug 17, 2026
| import java.util.HashMap; | ||
| import java.util.List; | ||
| import java.util.Map; | ||
| import java.util.Set; |
Collaborator
Author
There was a problem hiding this comment.
Just ran spotless apply
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We accidentally removed the changes from here: #237
There have been significant updates to the backup system since then, so I created a new PR to accommodate those changes. I will update the PR upstream to reflect these most recent changes