Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A
block_actionspayload containing"channel": {"id": "C123", "name": "general"}currently deserializes withgetChannel() == null, including when read asSlackInteractiveCallback. This is reproducible by adding that field to the existingblock_actions_with_message_container.jsonfixture; the new regression failed on the current master before the fix.Mark the existing default getter with
@Defaultand@Nullableso Immutables stores the supplied channel. Both channel ID and name now survive deserialization and serialization. The getter signature and default implementation remain unchanged for custom implementations. Missing or explicit-null channels remain accepted and omitted from serialized payloads, consistent with Slack's optional channel field. No channel is inferred fromcontainer.channel_id.Validation under Temurin 21.0.13:
BlockActionsSerializationTesttests pass afterward, covering direct/polymorphic roundtrips, absent/null channels, and builder copies.mvn -B -q clean install: 400 tests, 0 failures/errors, 3 existing skips (baseline: 395 tests, the same 3 skips).mvn -B -q spotless:checkandgit diff --checkpass.-t ../toolchains/toolchains.xmllocally to select the installed JDK. No project toolchain, dependency, version, generated-source, or CI files change.AI assistance: implemented and tested with OpenAI Codex, with a separate diff review.
Fixes #139