fix(footer): remove duplicated opening <a> in CC license icons - #3330
fix(footer): remove duplicated opening <a> in CC license icons#3330Vidminas wants to merge 1 commit into
Conversation
The Creative Commons icon link rendered two identical opening `<a>` tags followed by a single closing `</a>`, producing invalid nested-anchor HTML. Delete the duplicate opening tag. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
✅ Deploy Preview for academic-demo canceled.
|
|
Wow, your first PR! Welcome to the community! 🎉 Thank you for this contribution to open source and open research. It makes a huge impact for the thousands of innovators building with Hugo Blox. If you're wondering about next steps, please read our Contributor Guide for coding standards, how to run the project locally, and how to get help. We hope this is just the start of your journey with us. Let's build the future together! Join us on Discord to connect with the team and community. Awesome work, we'll take a look soon! ✨ |
|
This PR is stale because it has not had any recent activity. The resources of the project maintainers are limited, and so we are asking for your help. If you feel that the PR is still relevant in the latest release, consider making the PR easier to review and finding developers to help review the PR. Please be mindful that although we encourage PRs, we cannot expand the scope of the project in every possible direction. There will be requests that don't make the roadmap. This PR will automatically close soon if no further activity occurs. Thank you for your contributions. |
|
This is still relevant, keep open ^ |
The Creative Commons icon link rendered two identical opening
<a>tags followed by a single closing</a>, producing invalid nested-anchor HTML. Delete the duplicate opening tag.🚀 What type of change is this?
🎯 What is the purpose of this change?
The footer Creative-Commons license icons open with two identical
<a>tags but close witha single
</a>(site_footer_license.html), producing invalid nested-anchor HTML. Browsersrecover from it, but it's malformed markup and can confuse assistive tech and validators. I caught this during keyboard navigation accessibility testing.
Fix. Delete the duplicate opening
<a>.Verified on the
academic-cvstarter: the built footer now contains exactly onearia-label="Creative Commons"anchor with zero nested<a><a>sequences.📸 Screenshots or Screencast (if applicable)
n/a — no visual change; the fix is valid HTML (
<a><a><svg>…→<a><svg>…).ℹ️ Documentation Check
📜 Contributor Agreement
Thank you for your contribution!