a11y(bio): give social links human-readable aria-labels - #3338
Open
Vidminas wants to merge 1 commit into
Open
Conversation
The resume-biography-3 social links set `aria-label` to the raw icon slug, so screen readers announced e.g. "brands/github" or "academicons/google-scholar" (WCAG 4.1.2). Prefer the link's `label`; otherwise fall back to the humanized icon basename (e.g. `brands/github` -> "Github"). Authors can set an explicit `label` for exact wording. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
✅ Deploy Preview for academic-demo canceled.
|
Contributor
|
This PR is stale because it has not had any recent activity. The resources of the project maintainers are limited, and so we are asking for your help. If you feel that the PR is still relevant in the latest release, consider making the PR easier to review and finding developers to help review the PR. Please be mindful that although we encourage PRs, we cannot expand the scope of the project in every possible direction. There will be requests that don't make the roadmap. This PR will automatically close soon if no further activity occurs. Thank you for your contributions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The resume-biography-3 social links set
aria-labelto the raw icon slug, so screen readers announced e.g. "brands/github" or "academicons/google-scholar" (WCAG 4.1.2). Prefer the link'slabel; otherwise fall back to the humanized icon basename (e.g.brands/github-> "Github"). Authors can set an explicitlabelfor exact wording.🚀 What type of change is this?
🎯 What is the purpose of this change?
The social links in the
resume-biography-3block setaria-labelto the raw icon slug, soscreen readers announce link purposes as e.g. "brands/github", "academicons/google-scholar",
or "hero/link" (WCAG 4.1.2 — Name, Role, Value). Note the human-readable value already exists
in the template — it's just used for the
titletooltip, not the accessible name.Fix. Set
aria-labelto the link'slabelwhen present, otherwise the humanized iconbasename (
brands/github→ "Github",hero/link→ "Link"). Authors can set an explicitlabelfor exact casing (e.g. "GitHub").
Verified on the
academic-cvstarter: the six bio social links now exposeE-mail Me/X/Github/Linkedin/Google scholar/Orcid— no rawbrands/orhero/slugs remain in anyaria-label.📸 Screenshots or Screencast (if applicable)
n/a — accessible-name change; inspect the
aria-labelattributes or a screen reader.ℹ️ Documentation Check
📜 Contributor Agreement
Thank you for your contribution!