Support PI User Authentication mode with empty password#610
Open
Jinzy wants to merge 1 commit intoHugovdberg:developfrom
Open
Support PI User Authentication mode with empty password#610Jinzy wants to merge 1 commit intoHugovdberg:developfrom
Jinzy wants to merge 1 commit intoHugovdberg:developfrom
Conversation
…ovided with empty password.
Hugovdberg
requested changes
Dec 12, 2022
Owner
Hugovdberg
left a comment
Hugovdberg
left a comment
There was a problem hiding this comment.
Sorry for the late reply, I have been terribly busy with other projects.. I hope you can still respond to my request for a small change, otherwise I will see if I can make a new PR and attribute it to you.
| if server and server not in self.servers: | ||
| message = 'Server "{server}" not found, using the default server.' | ||
| warn(message=message.format(server=server), category=UserWarning) | ||
| if bool(username) != bool(password): |
Owner
There was a problem hiding this comment.
I think that a username without a password is a valid case, but a password without a user is still invalid, right? In that case we should not remove this check entirely, but make it more similar to the next check for a domain without a username.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support PI User Authentication mode, in the case of when user name provided while, with empty password.