Add Window::setParentWindow (macOS child windows)#312
Open
bumfo wants to merge 1 commit into
Open
Conversation
Attaches a window as a child of another so it stays above its parent within the application, without floating over other apps' windows (unlike ZOrder.FLOATING/MODAL_PANEL). Pass null to detach; hiding a child window detaches it automatically on macOS, so callers re-attach on show. Windows/X11: TODO stubs matching setZOrder. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
New API
Window.setParentWindow(@Nullable Window parent), implemented on macOS via-[NSWindow addChildWindow:ordered:](NSWindowAbove). A child window stays ordered above its parent within the application — unlikesetZOrder(FLOATING/MODAL_PANEL), it does not float above other applications' windows. Passingnulldetaches.Why
The floating
ZOrderlevels are global: a tool/palette window (robot consoles in my app's case) set toFLOATING/MODAL_PANELstays above every other application too. Child windows are the native macOS mechanism for "always above one specific window only".Notes / caveats
setVisible(true)on every show.setZOrderstub style (Win32 could later reuse the_nWinSetParentowner-window plumbing; X11 viaXSetTransientForHint).target/classes.🤖 Generated with Claude Code