Skip to content

test(audit-012): classify Shift_R observation as inconclusive (no product fix) - #14

Merged
Hylfrd merged 6 commits into
masterfrom
codex/audit-right-shift-keybinding
Aug 30, 2026
Merged

Hylfrd merged 6 commits into
masterfrom
codex/audit-right-shift-keybinding

Conversation

@Hylfrd

@Hylfrd Hylfrd commented Aug 24, 2026 •

Copy link
Copy Markdown
Owner

Audit-only correction for AUDIT-012. No production keybinding or input behavior is changed.

Scope

  • FarmHelperSettingsController.java is restored exactly to the fixed base controller blob 742a570ccc47bba19163d0d02ae1ec27d0ad614c.
  • Controller tests exercise the real 26.1.2 InputConstants/KeyMapping boundary and a test-only tick seam: KEYSYM/344 versus SCANCODE/54, right/left Shift identity, click queue consumption, one-screen opening, held/repeat suppression, existing-screen and unrelated-key guards, and remapped InputConstants.KEY_F6.
  • AUDIT-012 records P0-06 as PLAYER_TOOL_BLOCK/INCONCLUSIVE. It records upstream default F, the undocumented/unreviewed modern Right Shift difference, and offhand conflict only as an unproven hypothesis.

Evidence

  • The current-master event-to-KeyMapping harness consumed KeyEvent(344, 54, 0) as KEYSYM/344 and did not consume KeyEvent(-1, 54, 0) for a KEYSYM/344 mapping.
  • The supplied R4 Computer Use Shift_R action did not establish which event identity reached Minecraft, so no product root cause or fix is claimed.
  • Supplied P0-04 /fh open and P0-05 /farmhelper open paths passed; Builder performed no GUI, Computer Use, input, or Player rerun.

Local verification

  • 686 tests passed with 0 failures and 0 errors.
  • Focused settings/screen/command suite, check, verifyDependencyProvenance, and validateAccessWidener (NO-SOURCE) passed.
  • Two clean builds produced identical FarmHelper-26.1.2.jar SHA-256 42A79DC679FBD843FAAF40B601F1A7A5671C6BC1D452DF9E5913ED406C214C25, 890472 bytes.
  • Implementation candidate: 4ecbd39, tree 10c44db8f12a63d6a7a874b5ff70d7b508e802f7.
  • Final publication head: 322b40c. Exact-head PR CI run 32788620622 passed Linux / test, Linux / build, Windows / test, and Windows / build; matching push run 32788617000 also passed.

@Hylfrd Hylfrd changed the title fix(audit-012): repair default Right Shift settings keybinding test(audit-012): classify Shift_R observation as inconclusive (no product fix) Aug 24, 2026
@Hylfrd
Hylfrd merged commit a3a21cd into master Aug 30, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant