Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
feature/jacobevidence parser for cleaned Jacob contest text.count >= thresholdrule.Fixed upstream anchors
eacb323fbde3eff94d4f2ee7baacb059d84b8e3a,com.jelly.farmhelperv2.handler.GameStateHandler#checkJacob(String):jacob's contestidentifies the contest;jacobsRemainingTimePatternplusconvertCropidentifies the crop;Collectedand recognized medalwithlines supply the count.lastIndexOf(" ")followed by comma removal.com.jelly.farmhelperv2.failsafe.impl.JacobFailsafe#onTickDetection(ClientTickEvent): crop-specific caps are selected and the detection boundary is inclusive atgetJacobsContestCropNumber() >= cropThreshold.Verification
./gradlew.bat test --tests dev.hylfrd.farmhelper.feature.jacob.JacobThresholdDetectorTest --no-daemon --console=plain(11 tests passed)../gradlew.bat test --no-daemon --console=plain(passed)../gradlew.bat build --no-daemon --console=plain(passed; dependency provenance verified and access widener had no source).Composition risks