Skip to content

[WIP] Fix bash parse errors in pattern-loader.sh #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
noelsaw1 merged 2 commits into from
Mar 24, 2026
Merged

[WIP] Fix bash parse errors in pattern-loader.sh #124

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2957658
Initial plan
Copilot Mar 24, 2026
a4ccf5f
Fix bash local-outside-function errors in simple-pattern runner loop
Copilot Mar 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,8 @@ All notable changes to this project will be documented in this file.

### Fixed

- Fixed bash `local: can only be used in a function` errors that appeared on every scan invocation. The simple-pattern runner loop uses `local` in top-level scope; replaced with plain variable assignments

- N+1 pattern findings now include the actual source code line in the report. Previously the `code` field was empty because `find_meta_in_loop_line` only returned the line number without extracting the source text

### Tests
Expand Down
8 changes: 4 additions & 4 deletions dist/bin/check-performance.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6054,10 +6054,10 @@ if [ -n "$SIMPLE_PATTERNS" ]; then
include_args="--include=*.php"
fi

local exclude_file_globs=""
local exclude_line_patterns=""
local exclude_file_contains=""
local current_exclusion_block=""
exclude_file_globs=""
exclude_line_patterns=""
exclude_file_contains=""
current_exclusion_block=""

while IFS= read -r json_line; do
case "$json_line" in
Expand Down
Loading