Pass user agent to auction telemetry - #1103
Open
ChristianPavilonis wants to merge 1 commit into
Open
Conversation
This was referenced Aug 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Passes the request
User-Agentthrough each auction observation and every emitted Tinybird row./auctionreads the value fromAuctionRequest.device.user_agent.auction_events_rawgains a nullableuser_agentstring column.This deliberately does not classify
browser_familyat the edge. Downstream data syncs own browser aggregation, as requested in the review of #1039.Contract change
The complete User-Agent is now intentionally retained in raw auction telemetry, including skipped and consent-denied observations, under the datasource's existing 30-day TTL. The telemetry design and implementation plan now document this contract. EC IDs, internal auction request IDs, IP addresses, full URLs, query strings, and fragments remain excluded.
Why
Edge-side browser classification fixes the aggregation policy in application code and discards information that downstream data syncs may need. Keeping the source value lets each sync derive the browser dimensions it requires without another edge deployment.
Supersedes #1039 and addresses its requested change.
Related to #979
Verification
cargo fmt --all -- --checkcargo test-fastlycargo test-axumcargo test-cloudflarecargo test-spincargo test --manifest-path crates/trusted-server-integration-tests/Cargo.toml --test paritycargo clippy-fastlycargo clippy-axumcargo clippy-cloudflarecargo clippy-cloudflare-wasmcargo clippy-spin-nativecargo clippy-spin-wasmcd crates/trusted-server-js/lib && npx vitest runcd crates/trusted-server-js/lib && npm run formatcd docs && npm run formattb check tinybird/datasources/auction_events_raw.datasourceRollout
Deploy the additive Tinybird datasource column before deploying the edge version. Older rows and requests without a valid User-Agent remain null.