feat: add FMSR and utility catalog MCP tools#431
Open
ShuxinLin wants to merge 7 commits into
Open
Conversation
DhavalRepo18
reviewed
Jul 6, 2026
DhavalRepo18
left a comment
Collaborator
There was a problem hiding this comment.
While adding a catalog, we should add
- A few sample files in the catalog
- Update the manifest file (defaults)
- revise the docs
- enrich the docs (doc string) for more information
Signed-off-by: Shuxin Lin <linshuhsin@gmail.com>
Signed-off-by: Shuxin Lin <linshuhsin@gmail.com>
Signed-off-by: Shuxin Lin <linshuhsin@gmail.com>
Add one-row synthetic catalog samples and allowlist the new catalog CSV files. Signed-off-by: Shuxin Lin <linshuhsin@gmail.com>
Add a failure_mode CouchDB collection config and a one-document synthetic FMEA sample. Inline the curated FMSR failure-mode mapping so the obsolete YAML data file can be removed. Signed-off-by: Shuxin Lin <linshuhsin@gmail.com>
82dbc9f to
b6a44da
Compare
Signed-off-by: Shuxin Lin <linshuhsin@gmail.com>
Signed-off-by: Shuxin Lin <linshuhsin@gmail.com>
DhavalRepo18
reviewed
Jul 8, 2026
DhavalRepo18
left a comment
Collaborator
There was a problem hiding this comment.
I count not review the FMSR MCP Server need to change its doc string. ideally all tool information we should be getting from their tool so we shpould look how other servers are defined.
| instructions="General utilities: read JSON files and get current date/time.", | ||
| instructions=( | ||
| "General utilities: read JSON files, get current date/time, and query " | ||
| "asset, sensor, and failure-mode catalog data from CouchDB." |
Collaborator
There was a problem hiding this comment.
Not Sure we need to say from CouchDB?
We should avoid referring CouchDB.
| def get_sensor_catalog( | ||
| sensor: Optional[str] = None, | ||
| ) -> Union[CatalogResult, ErrorResult]: | ||
| """Return sensor catalog entries. Pass sensor for an exact sensor-name lookup.""" |
Collaborator
There was a problem hiding this comment.
We should also say what it will return> a list of all the sensor a machine can have? etc
Collaborator
|
this one |
Collaborator
|
The docstring needs to be unified across all MCPs. The current docstring gives a hint on what to do. We keep the docstring clean. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the FMSR scenario support path by expanding the FMSR MCP tools and adding catalog lookup tools to the utilities MCP server.
The goal is to give FMSR scenarios a catalog-backed tool surface for asset, sensor, and failure-mode context, while keeping generated FMSR reasoning separate from stored catalog/failure-mode reads.
Key changes:
failure_modecollection.failure_codecollection key.Type of Change
Industry Relevance
FMSR scenarios depend on reliable failure-mode, sensor, and asset context. Moving those reads into catalog-backed MCP tools lets agents ground FMSR reasoning in benchmark data first, then use LLM generation only when stored failure-mode coverage is absent or explicitly partial.
Related Issues
Testing & Validation
src/servers/fmsr/tests/andsrc/servers/utilities/tests/.Current GitHub checks on the latest PR head are passing for DCO and secret scans (
Gitleaks,TruffleHog).Suggested local validation before merge:
Checklist