fix: root redirect uses app_root_path with trailing slash #1547
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ESnark
force-pushed
the
remove-unnecessary-redirect
branch
from
7e20d4f to
7ab5bb7
Compare
- Changed from request.scope.get("root_path") to settings.app_root_path
for consistency with other parts of the codebase
- Added trailing slash (/admin/) to avoid 307 redirect
- Removed unused request parameter from root_redirect function
- Updated tests to verify correct redirect path with app_root_path
Closes IBM#1547
Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>
crivetimihai
force-pushed
the
remove-unnecessary-redirect
branch
from
404deb5 to
0b0b3ad
Compare
4 tasks
crivetimihai
approved these changes
Dec 12, 2025
Member
There was a problem hiding this comment.
Thanks. Created a GitHub issues for other similar consistency issues #1588
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🐛 Bug-fix PR
Before opening this PR please:
make lint- passesruff,mypy,pylintmake test- all unit + integration tests greenmake coverage- ≥ 90 %make docker docker-run-sslormake podman podman-run-ssl📌 Summary
Root path redirect (
/→/admin/) was ignoring APP_ROOT_PATH setting and causing unnecessary 307 redirect.🔁 Reproduction Steps
APP_ROOT_PATH=/apiGET /api/admin/instead of/api/admin/🐞 Root Cause
root_redirectfunction usedrequest.scope.get("root_path", "")which returns empty string, while other parts of the codebase usesettings.app_root_path. Also missing trailing slash caused extra 307 redirect.💡 Fix Description
request.scope.get("root_path")tosettings.app_root_pathfor consistency (missing from fix: Export virtual server URLs now respect APP_ROOT_PATH configuration #1332 )/admin/) to avoid 307 redirect🧪 Verification
make lintmake testmake coverage📐 MCP Compliance (if relevant)
✅ Checklist
make black isort pre-commit)