Skip to content

Conversation

@pyrooka
Copy link
Member

@pyrooka pyrooka commented Nov 25, 2025

PR summary

This PR replaces the remaining safeLoad function calls with the new load and updates the transitive js-yaml dependency in the package-lock.json to fix a recent CVE.

PR Checklist

General checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • Dependencies have been updated as needed
  • .secrets.baseline has been updated as needed
  • npm run update-utilities has been run if any files in packages/utilities/src have been updated

Checklist for adding a new validation rule:

  • Added new validation rule definition (packages/ruleset/src/rules/*.js, index.js)
  • If necessary, added new validation rule implementation (packages/ruleset/src/functions/*.js, updated index.js)
  • Added new rule to default configuration (packages/ruleset/src/ibm-oas.js)
  • Added tests for new rule (packages/ruleset/test/*.test.js)
  • Added docs for new rule (docs/ibm-cloud-rules.md)
  • Added scoring rubric entry for new rule (packages/validator/src/scoring-tool/rubric.js)

Signed-off-by: Norbert Biczo <pyrooka@users.noreply.github.com>
Signed-off-by: Norbert Biczo <pyrooka@users.noreply.github.com>
@pyrooka pyrooka requested a review from diatrcz November 26, 2025 16:09
@pyrooka pyrooka marked this pull request as ready for review November 26, 2025 16:10
Copy link
Contributor

@diatrcz diatrcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@pyrooka pyrooka merged commit 6077c45 into main Nov 26, 2025
7 checks passed
@pyrooka pyrooka deleted the nb/update-jsyaml branch November 26, 2025 17:03
ibm-devx-sdk pushed a commit that referenced this pull request Nov 26, 2025
## ibm-openapi-validator [1.37.6](https://github.com/IBM/openapi-validator/compare/ibm-openapi-validator@1.37.5...ibm-openapi-validator@1.37.6) (2025-11-26)

### Bug Fixes

* replace remaining `safeLoad` with `load` ([#773](#773)) ([6077c45](6077c45))
@ibm-devx-sdk
Copy link

🎉 This PR is included in version 1.37.6 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

@ibm-devx-sdk
Copy link

🎉 This PR is included in version 1.33.4 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants